1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/sbbsecho.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, October 22, 2025 09:34:08
    https://gitlab.synchro.net/main/sbbs/-/commit/faf0f4d29ca57bdcc0d130c5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix handling of .msg files from IBBS doors.

    IBBS doors configured for Binkley style outbound will put the
    binkley directives in the subject, expecting them to pass through
    to the FLO file.

    SBBSEcho v2 and v3 since a3b2f9e2d have stripped the "delete file"
    indication ('^') and generated an error, refusing to send messages
    with #, ~, -, !, and @.

    This changes the behaviour to translate '-' to '^', '!' to '~', and
    strip '@', and keep the prefix that was in the .msg file.

    This fixes the issue where outbound files from IBBS games configured
    for Binkley style outbound would never get deleted.

    Note that in this implementation, the prefix overrides the configured truncation value and any "FLAGS KFL" kludge lines.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, October 22, 2025 09:38:49
    https://gitlab.synchro.net/main/sbbs/-/commit/377ac0563666ae3852f33cef
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix last commit to not include the prefix when validating the filename

    Derp.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, October 22, 2025 09:52:06
    https://gitlab.synchro.net/main/sbbs/-/commit/aa7a1b6505417cfcdcc8530b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Previous "fix" actually broke more than it fixed.

    I wouldn't call me a real developer.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, October 31, 2025 19:44:42
    https://gitlab.synchro.net/main/sbbs/-/commit/3b527199322f25832617f964
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix potential buffer overflow in fmsgattr_str()

    Pass it 0xffff and it overflows its local (static) string buffer.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Friday, October 31, 2025 20:24:54
    https://gitlab.synchro.net/main/sbbs/-/commit/41e2191514f2a45fe862b6b4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace import_netmail() magic constansts with (expanded) IMPORT_* enum values

    The only really important values (other than for debug-logging reasons) are
    0 (success) and IMPORT_CLOSED (was -2).

    One functional change included here: when fmsgtosmsg returned non-zero values, import_netmail() would log the value and still return 0 (success). This will result in more debug-level log msgs when fmsgtosmsg() returns an error value, but that's all.

    The logged import_netmail() error numbers *are* changed by this commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Friday, October 31, 2025 23:19:30
    https://gitlab.synchro.net/main/sbbs/-/commit/d5b59539e7e688f57ce3c43e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Implement Deuce's suggested fix for importing netmail messages (.msg files)

    ... for robots.

    I thought he said he was importing packets, but in any case, we don't want to be deleting a .msg file destined for a configured robot.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, November 01, 2025 13:48:11
    https://gitlab.synchro.net/main/sbbs/-/commit/e7b93ae3f3f8dfb24d450f1c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Clean up import_netmail()

    - No longer use special return value (IMPORT_CLOSED) to indicate the .msg
    file was closed. Now we just set the FILE* to NULL if it was closed and
    return IMPORT_SUCCESS.
    - No longer deletes the .msg file here; expect the caller (main()) to do that. - Update the message header here (e.g. adding "RECEIVED" attribute flag),
    when appropriate. Sometimes this was added here, sometimes in the main(),
    and in some cases it should not have been added (e.g. for ignored and
    filtered netmail messages) but it was anyway.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, November 01, 2025 14:11:05
    https://gitlab.synchro.net/main/sbbs/-/commit/5b21df6e401a7b3071c44f8b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit

    Weird that it compiled without warning. I didn't try linking it, so that's why it wasn't caught.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, November 09, 2025 14:47:50
    https://gitlab.synchro.net/main/sbbs/-/commit/f8a33572e1e6fe5ac9887856
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Remove direct printf() calls from import_netmail()

    ... direct all output through lprintf() instead.

    This insures that the helpful output may always be logged to the sbbsecho.log file and the sysop need not view the stdout to find out why a netmail message was ignored or discarded or otherwise problematic.

    It appeared there may have been redundant output to stdout before anyway and trying to keep both the stdout and the log output both helpful and beautified was getting tedius.

    Most sysops don't look at the console/stdout of sbbsecho when it runs and we normally expect a sysop to be able to use the sbbsecho.log file to debug any issues (possibly after increasing their log level to DEBUG).

    Include the netmail message attributes value (both in hex and verbose form)
    in the information logged about an incoming netmail message.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, December 10, 2025 17:12:44
    https://gitlab.synchro.net/main/sbbs/-/commit/e69955e0e7e951634ad90f48
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace integer constants 0 and 1 with values of appropriate type (e.g. bool)

    Code clean-up, no functional change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, December 24, 2025 19:50:40
    https://gitlab.synchro.net/main/sbbs/-/commit/241bd37f9feb34506c3b295d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Better logging around area list file open failures

    This also fixes the empty "Title" key/valiue lines in the echostats.ini file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Denn@VERT/OUTWEST to Gamgee on Saturday, December 27, 2025 12:02:57
    Re: Re: src/sbbs3/sbbsecho.c
    By: Gamgee to MRO on Tue Feb 04 2025 06:41 pm

    MRO wrote to k9zw <=-
    Alas my system merged this in another echo... puzzling how at the
    moment... appreciate the reply!

    put your data files in their own sub directory for each msg network
    you have.

    That isn't necessary and certainly is not the default way.

    But it does keep the directories a little tidier.

    ... Remember how simple life was when there were only two sexes?

    ---
    þ Synchronet þ the Outwest BBS - outwest.synchro.net - Home of BBSBASE 6.0
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, February 18, 2026 17:30:14
    https://gitlab.synchro.net/main/sbbs/-/commit/9c4557e96766bb7e6b73edf4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix a couple more new-GCC warnings

    using gcc (GCC) 15.2.1 20260209 "assignment discards const qualifier"

    reported by Accession

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, April 18, 2026 02:27:17
    https://gitlab.synchro.net/main/sbbs/-/commit/3422dabc7807f1fff56ebb9e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix compile errors on GCC 15.2

    error: passing argument 2 of `getfmsg' from incompatible pointer type [-Wincompatible-pointer-types]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 19:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/326057fd5c56c0c77a5e0d34
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: free pkt->filename on fopen failure in find_stray_packets (CID 530517)

    When the new outpkt_t cannot be opened for append, free(pkt) was called
    without first releasing the strdup'd pkt->filename, leaking the path
    for every stray packet whose append-open fails.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 19:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/9ef727bc25d13118b3ba5323
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: cast away unchecked chmod/remove returns in alter_areas (CIDs 462777, 515046)

    Both calls in alter_areas() are best-effort: the chmod is a permission
    preserve before rename, and the remove is documented to be expected to
    fail when the file doesn't exist. Make the ignore-return intent explicit
    with (void) casts so Coverity stops flagging them as CHECKED_RETURN.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, July 17, 2026 02:57:08
    https://gitlab.synchro.net/main/sbbs/-/commit/4fc976e4a95c2afe121425e6
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't import netmail addressed to an inactive user's number

    import_netmail() resolves a numeric "To:" field with atoi() straight from
    the packet, which short-circuits lookup_user() -- the only thing in this
    path that skips deleted users. Nothing downstream catches it either: fmsgtosmsg() calls getuserdat(), which returns USER_SUCCESS for a deleted record, and no check guards the RECIPIENTEXT field written from it. A
    remote system could therefore deposit netmail into a deleted user's
    record, where it stays invisible until the record is recycled.

    Reject an inactive account where the number is resolved, so the message
    falls through to the existing lookup_user() / default_recipient /
    "Unknown user" handling rather than changing what fmsgtosmsg() reports to
    its callers. This matches the SMTP RCPT TO path, which already rejects a recipient that isn't an active account.

    Fixes #1187

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Steven Philley@VERT to Git commit to main/sbbs/master on Thursday, September 10, 2026 01:17:29
    https://gitlab.synchro.net/main/sbbs/-/commit/4a76e2aa9a8336d7bda238ed
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: summarize security violations at end of log

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, September 10, 2026 01:17:29
    https://gitlab.synchro.net/main/sbbs/-/commit/094414dbc737da32df2062c9
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Merge branch 'sbbsecho-security-violation-summary' into 'master'

    sbbsecho: summarize security violations at end of log

    Closes #1228

    See merge request main/sbbs!730

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, September 29, 2026 19:00:50
    https://gitlab.synchro.net/main/sbbs/-/commit/1debd362b1e3c690856c91b6
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    SBBSecho: export a message's declared charset as its CHRS

    A message posted with a MIME charset other than UTF-8 (for example from an
    NNTP client set to ISO-8859-1 or Windows-1252) was exported to FidoNet as "CHRS: CP437 2", so FTN readers mis-rendered its accented characters.

    Netmail and echomail export now share ftn_charset(). When a message has
    8-bit body text, no FTN charset and is not UTF-8, its MIME charset is
    mapped to the matching FTS-5003 identifier: LATIN-1/2/5/9, CP1250/1251/
    1252, CP850/852/866 (or CP437). Names are matched ignoring case, '-' and
    '_'. Charsets FTS-5003 has no identifier for still export as CP437.

    The configured origin line is CP437, so it is reduced to ASCII when the
    message goes out in one of those other 8-bit charsets. A message whose
    only 8-bit text is the origin line is still labeled CP437.

    Fixes #1259

    Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, September 29, 2026 19:00:50
    https://gitlab.synchro.net/main/sbbs/-/commit/6c6d3dcbf9c50003d7ec9938
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    SBBSecho: give each generated NetMail a unique MSGID serial

    The MSGID of a NetMail message SBBSecho creates itself (AreaMgr replies,
    notify lists, etc.), added in 96712a1c35 (focuses-28-lives, 2021-11-12),
    used the current time in seconds as its serial. Messages created within
    the same second, such as the parts of a notify or area list split across several NetMails to one node, therefore shared a MSGID, which FTS-0009
    requires to be unique for the origin address, and which a receiving
    tosser checking NetMail for duplicates by MSGID could discard.

    The serial is now the current time, or one more than the last serial
    used, whichever is greater.

    Related: #1257

    Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, October 27, 2026 19:41:34
    https://gitlab.synchro.net/main/sbbs/-/commit/ad0cde5491bfdcf99dc292ab
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: bundle full packets immediately; keep long runs from going stale

    A remote AreaFix RESCAN of every area could fill the disk: outbound
    packets that reached the maximum packet size were held in the temp
    directory until the end of the run, so a large export accumulated every exported message there, uncompressed (32 GB in the reported case). The ever-growing temp directory and outbound packet list also made each new
    packet slower to create, stretching the run to about 20 hours.

    - Bundle each outbound packet as soon as it is full, and drop it from
    the outbound packet list. pktname() no longer reuses a name within a
    run: a packet already moved into a bundle no longer exists on disk,
    and a same-named packet would replace it inside that bundle.

    - During long runs, refresh the time stamps of sbbsecho.bsy and the BSO
    node lock files (at most once a minute), so a run that outlasts
    BsyTimeout isn't considered stale and joined by a concurrent instance.

    - Check MinFreeDiskSpace for the temp and outbound directories before
    creating each new outbound packet, and stop gracefully (as on a
    termination signal) rather than writing until the disk is full.

    - When an echomail export stops early, save the export pointer of the
    last message processed instead of the sub-board's last message, so
    the remaining messages are exported by the next run rather than
    skipped. This also affected an export interrupted with Ctrl-C.

    Fixes #1301

    Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net